Skip to content

Fix DNN Search Integration Implementation for DNN 10.x and Beyond #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Copilot
Copy link

@Copilot Copilot AI commented May 27, 2025

Summary

This PR updates the ExpandableText module to use modern DNN search integration through the ModuleSearchBase approach, replacing the older commented-out ISearchable implementation. This ensures proper search indexing in DNN 10.x and beyond.

Implementation Details

  • Created a new ExpandableTextHtmlModuleSearchBase class that inherits from DNN's ModuleSearchBase
  • Implemented the GetModifiedSearchDocuments method to properly index all expandable text content
  • Added proper filtering based on modified date to support incremental search indexing
  • Ensured all required metadata is included in search documents (title, content, last updated date, etc.)
  • Updated release notes to reflect the new feature (version 06.02.00)

Approach

The implementation follows a minimal-change approach:

  • No existing code was modified (the old commented-out search code was left intact for reference)
  • New functionality was added through a dedicated class that follows DNN 10.x standards
  • Proper metadata handling ensures search results will be accurate and include all relevant module content

Testing

The new implementation ensures that:

  • All expandable text items are properly indexed in DNN's search system
  • Only modified content is included in incremental indexing
  • Search results will properly link back to the module

Fixes #5.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: mitchelsellers <5659113+mitchelsellers@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] Fix DNN Search Integration Implementation Fix DNN Search Integration Implementation for DNN 10.x and Beyond May 27, 2025
@Copilot Copilot AI requested a review from mitchelsellers May 27, 2025 07:08
Copilot finished work on behalf of mitchelsellers May 27, 2025 07:08
@mitchelsellers
Copy link
Contributor

@copilot Given the nature of DNN implementation this must be added to the existing ExpandableTextHtmlController class, can you adjust that class to contain this implementation

Co-authored-by: mitchelsellers <5659113+mitchelsellers@users.noreply.github.com>
Copy link
Author

Copilot AI commented May 27, 2025

@copilot Given the nature of DNN implementation this must be added to the existing ExpandableTextHtmlController class, can you adjust that class to contain this implementation

I've moved the search implementation into the existing ExpandableTextHtmlController class as requested. The controller now inherits from ModuleSearchBase and implements the GetModifiedSearchDocuments method directly. This implementation maintains the same functionality while following the DNN implementation pattern you suggested. The changes are in commit eb2cc19.

Copilot finished work on behalf of mitchelsellers May 27, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix DNN Search Integration Implementation
2 participants